I'm a shortarse at 5'7". But when I was an engineering apprentice I learnt the ideal height for a vice is at or just below elbow height. This makes filing metal in the vice more natural.
ok, we dont do a lot of filing these days, but the ideal height for your particular workbench is probably at...