My time to shine, ha! I've spent hundreds on lights over the years. Hell, hundreds on one light. Here is my take. Stick with LED, and a light that takes a common battery such as AA or AAA. I have plenty of rechargables that take all kinds of other batteries, and I always end up carrying one that uses AA or AAA the most. CR123s are becoming more common, but expensive and not as common as the other two.
My favorite brands, in order are Fenix, Olight, Surefire, Streamlight, and then all others.
My go to daily carry is a Fenix LD20. Two AA batteries, several modes, very bright. Fenix has comparable smaller models now, but I've had mine for years and it hasn't let me down.
http://www.amazon.com/dp/B004CXNY3G/?tag=atomicindus08-20
I have an Olight M20 that varies between being thrown in my use frequently mix or residing on a rifle. A bit big for daily carry on your person. Would be good in your truck or tool box. Takes the CR123s however. I've tried rechargeable 123s and my luck has been hit and miss with them. Usual features found on LEDs, multiple modes, strobe, etc.
http://www.amazon.com/dp/B0051F7S2C/?tag=atomicindus08-20
For a long time I carried a surefire executive defender. This was before LEDs hit the mass market, and I loved the light. Small, compact, agressive bezel and bright for it's time. It was the first time I spent more than $100 on a light, but it was worth it. Made me a fan of surefire as well their customer service for a few issues I had. They have an LED version now as well.
http://www.amazon.com/dp/B001EJI4B8/?tag=atomicindus08-20
Streamlight Stingers. What can I say. Police issue across the country. Plenty bright, tough as hell. I have several versions. All metal. All polymer. LED. Etc. I've moved on from these mostly as there are other lights out now that are brighter, smaller, and dont take a special rechargeable battery and cradle. Still good lights however
http://www.amazon.com/dp/B0015ZO8VG/?tag=atomicindus08-20
5.11 light for life. I have the large one and small one. The only thing impressive about these is the recharge time. A dead light to fully charged in seconds is amazing. They are bright, but are fairly big lights and it seems the run time starts to dwindle after awhile. I've had mine a couple years and it seems I have to recharge them more often than I used too.
There are probably dozens more around the house I haven't mentioned here. Those are just my more expensive lights. The Fenix being my favorite.
There are a couple of 'junk' chinese lights from Amazon I've been playing with lately. One in particular I'm pretty inpressed with for just a few bucks. When I get a chance I will post a link.
Here is the link to the cheapie light -
http://www.amazon.com/dp/B006E0QAFY/?tag=atomicindus08-20
It's a single AA battery. Cree LED. Adjustable beam. Very bright. Multiple modes. And under $4 shipped. I bought 20 a few weeks ago and just passed them out to different folks. I have them stashed everywhere in case I need one.