The longevity of spray foam and its impact on steel are a concern for us.
IMHO, these are exacerbated by building manufacturers who want to sell you additional "accessories". Accessories being defined as inferior insulation products.
The are unexplained premature rust through conditions on some buildings and some manufacturers are voiding warranties with the use of spray foam.
Have you even seen one of these cases first hand? Because I haven't. It's commonly pointed out that foam over steel will void the warranty. But you know what else voids warranties on steel? Leaks. Any leak. With any insulation type.
Likely the warranty covers the cost of the steel panel anyway, not the removal or re-install.
I've seen foam used on hangers (aircraft) here for going on 2 decades. I have yet to see one building with major issues that were factually attributed to foam. Now if your building leaks and closed cell holds that water on a panel, that's a thing... But again, that's not a foam failure.
What is factual is that if you damage or have to replace steel siding that has foam insulation on it, you're going to be re-doing the insulation too. That's one down side. The other mistake that I've seen is using lighter gauge steel and I've seen some foam applications that are capable of displacing that light steel enough that you can see it... then you end up with mess.
I get it, lots of people use it and are very happy with it, just not a risk of trapping moisture on steel I want to take.
Then use open cell, which will leak just like regular old insulation does.
Clearly I'm a fan, but I've also got no reason to steer you wrong on this.. I'm on my 3rd structure with foam (open cell) and have seen tons of buildings built this way.
For the dollar, I'm actually a fan of "hybrid" insulation. Spray foam the roof deck - it really cuts the labor and use traditional on the vertical walls (I assume there is framing).
BTW, for "sometimes cooled" shops, I don't go the full recommended R value on insulation... Those values assume full time heat/cooling use with climate zone.