We made switch to tankless 2 years ago. Replacing a conventional hot water heater and hot water boiler with a Rinnai combi unit.
Hot water delivery is *slower* to start, but it's as hot as you can bear and with unlimited fuel, unlimited hot water supply. With no metric as to water usage before and after, energy usage is down 15% compared to two separate units. Practically eliminated temperature swings as boiler is able to throttle heat output vs outdoor temp.
Cost.. roughly 2.5x conventional hot water heater, esp if you opt for combi or more premium units. We opted for 15yr warranty model. Despite self install, our utility still credited us for installing more energy efficient appliance. Nice chunk of change.
To remedy the slow delivery, I added a circulator that turns on and forces hot water to circulate back through cold water line to speed up delivery. I have it set to run about 90 seconds triggered off a flow switch.
Space savings was a *nice* bonus. Maintenance is about hour worth of effort once a year and $20 worth of vinegar solution.