I've used spray foam extensively since 2010. Other than the initials cost, there are very few drawbacks. It will pay for itself if you heat and cool the space. ROI varies with size, climate and usage.
If you have smells inside a foam sprayed building, it's gonna take air flow to remove...